Commit a78b32d9 authored May 22, 2019 by Pierre-Louis Bossart Committed by Vinod Koul May 27, 2019

soundwire: cadence_master: log Slave status mask on errors



The Slave status mask exposes 4 sticky bits. When the device loses
sync, the IP will report two status but the log will only show that
the device lost sync. The status mask has all the information needed
so let's report it instead.

Also change the resolution of the mask, using 64 bits is not needed
when you need 4.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent eb7df4c8

drivers/soundwire/cadence_master.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -487,7 +487,8 @@ static int cdns_update_slave_status(struct sdw_cdns *cdns,
		{
		enum sdw_slave_status status[SDW_MAX_DEVICES + 1];
		bool is_slave = false;
		u64 slave, mask;
		u64 slave;
		u32 mask;
		int i, set_status;

		/* combine the two status */
		@@ -527,7 +528,7 @@ static int cdns_update_slave_status(struct sdw_cdns *cdns,
		if (set_status > 1) {
		dev_warn_ratelimited(cdns->dev,
		"Slave reported multiple Status: %d\n",
		status[i]);
		mask);
		/*
		* TODO: we need to reread the status here by
		* issuing a PING cmd

Admin message