PCI: imx6: Make use of BIT() in constant definitions (276c76d7) · Commits · 戴 / test

Avoid using explicit left shifts and convert various definitions to use BIT() instead. No functional change intended. Signed-off-by:

Andrey Smirnov <andrew.smirnov@gmail.com> Signed-off-by:

Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Reviewed-by:

Lucas Stach <l.stach@pengutronix.de> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Chris Healy <cphealy@gmail.com> Cc: Lucas Stach <l.stach@pengutronix.de> Cc: linux-kernel@vger.kernel.org Cc: linux-pci@vger.kernel.org

drivers/pci/controller/dwc/pci-imx6.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -118,14 +118,14 @@ struct imx6_pcie {

		/* PHY registers (not memory-mapped) */
		#define PCIE_PHY_ATEOVRD 0x10
		#define PCIE_PHY_ATEOVRD_EN (0x1 << 2)
		#define PCIE_PHY_ATEOVRD_EN BIT(2)
		#define PCIE_PHY_ATEOVRD_REF_CLKDIV_SHIFT 0
		#define PCIE_PHY_ATEOVRD_REF_CLKDIV_MASK 0x1

		#define PCIE_PHY_MPLL_OVRD_IN_LO 0x11
		#define PCIE_PHY_MPLL_MULTIPLIER_SHIFT 2
		#define PCIE_PHY_MPLL_MULTIPLIER_MASK 0x7f
		#define PCIE_PHY_MPLL_MULTIPLIER_OVRD (0x1 << 9)
		#define PCIE_PHY_MPLL_MULTIPLIER_OVRD BIT(9)

		#define PCIE_PHY_RX_ASIC_OUT 0x100D
		#define PCIE_PHY_RX_ASIC_OUT_VALID (1 << 0)
		@@ -148,8 +148,8 @@ struct imx6_pcie {
		#define PCIE_PHY_CMN_REG26_ATT_MODE 0xBC

		#define PHY_RX_OVRD_IN_LO 0x1005
		#define PHY_RX_OVRD_IN_LO_RX_DATA_EN (1 << 5)
		#define PHY_RX_OVRD_IN_LO_RX_PLL_EN (1 << 3)
		#define PHY_RX_OVRD_IN_LO_RX_DATA_EN BIT(5)
		#define PHY_RX_OVRD_IN_LO_RX_PLL_EN BIT(3)

		static int pcie_phy_poll_ack(struct imx6_pcie *imx6_pcie, int exp_val)
		{

Admin message