Commit 25e1ed6e authored Jun 21, 2016 by Oliver Hartkopp Committed by Marc Kleine-Budde Jun 23, 2016

can: fix oops caused by wrong rtnl dellink usage



For 'real' hardware CAN devices the netlink interface is used to set CAN
specific communication parameters. Real CAN hardware can not be created nor
removed with the ip tool ...

This patch adds a private dellink function for the CAN device driver interface
that does just nothing.

It's a follow up to commit 993e6f2f ("can: fix oops caused by wrong rtnl
newlink usage") but for dellink.

Reported-by: ajneu <ajneu1@gmail.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent bce271f2

drivers/net/can/dev.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -1011,6 +1011,11 @@ static int can_newlink(struct net src_net, struct net_device dev,
		return -EOPNOTSUPP;
		}

		static void can_dellink(struct net_device dev, struct list_head head)
		{
		return;
		}

		static struct rtnl_link_ops can_link_ops __read_mostly = {
		.kind = "can",
		.maxtype = IFLA_CAN_MAX,
		@@ -1019,6 +1024,7 @@ static struct rtnl_link_ops can_link_ops __read_mostly = {
		.validate = can_validate,
		.newlink = can_newlink,
		.changelink = can_changelink,
		.dellink = can_dellink,
		.get_size = can_get_size,
		.fill_info = can_fill_info,
		.get_xstats_size = can_get_xstats_size,

Admin message