Commit 993e6f2f authored Aug 11, 2009 by Oliver Hartkopp Committed by David S. Miller Aug 13, 2009

can: fix oops caused by wrong rtnl newlink usage

For 'real' hardware CAN devices the netlink interface is used to set CAN
specific communication parameters. Real CAN hardware can not be created with
the ip tool ...

The invocation of 'ip link add type can' lead to an oops as the standard rtnl
newlink function was called:

http://bugzilla.kernel.org/show_bug.cgi?id=13954



This patch adds a private newlink function for the CAN device driver interface
that unconditionally returns -EOPNOTSUPP.

Signed-off-by: Oliver Hartkopp <oliver@hartkopp.net>
Reported-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
CC: Patrick McHardy <kaber@trash.net>
CC: Wolfgang Grandegger <wg@grandegger.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 839d1624

drivers/net/can/dev.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -611,11 +611,18 @@ nla_put_failure:
		return -EMSGSIZE;
		}

		static int can_newlink(struct net_device *dev,
		struct nlattr tb[], struct nlattr data[])
		{
		return -EOPNOTSUPP;
		}

		static struct rtnl_link_ops can_link_ops __read_mostly = {
		.kind = "can",
		.maxtype = IFLA_CAN_MAX,
		.policy = can_policy,
		.setup = can_setup,
		.newlink = can_newlink,
		.changelink = can_changelink,
		.fill_info = can_fill_info,
		.fill_xstats = can_fill_xstats,

Admin message