Commit 2287c636 authored Jan 13, 2017 by Yazen Ghannam Committed by Borislav Petkov Jan 16, 2017

EDAC, amd64: Save and return err code from probe_one_instance()



We should save the return code from probe_one_instance() so that it can
be returned from the module init function. Otherwise, we'll be returning
the -ENOMEM from above.

Signed-off-by: Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/1484322741-41884-1-git-send-email-Yazen.Ghannam@amd.com


Signed-off-by: Borislav Petkov <bp@suse.de>

parent f5c61277

drivers/edac/amd64_edac.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -3466,14 +3466,16 @@ static int __init amd64_edac_init(void)
		if (!msrs)
		goto err_free;

		for (i = 0; i < amd_nb_num(); i++)
		if (probe_one_instance(i)) {
		for (i = 0; i < amd_nb_num(); i++) {
		err = probe_one_instance(i);
		if (err) {
		/* unwind properly */
		while (--i >= 0)
		remove_one_instance(i);

		goto err_pci;
		}
		}

		setup_pci_device();

Admin message