Commit f5c61277 authored Jan 16, 2017 by Arvind Yadav Committed by Borislav Petkov Jan 16, 2017

EDAC, i82975x: Add ioremap_nocache() error handling

If ioremap_nocache() fails, it will return NULL. Which will then cause a
NULL-pointer dereference. Handle the returned value properly.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: "Arvind R." <arvino55@gmail.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/1484549092-11349-1-git-send-email-arvind.yadav.cs@gmail.com

[ Boris: massage commit message and improve error message. ]
Signed-off-by: Borislav Petkov <bp@suse.de>

parent eca90a3b

drivers/edac/i82975x_edac.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -494,6 +494,10 @@ static int i82975x_probe1(struct pci_dev *pdev, int dev_idx)
		}
		mchbar &= 0xffffc000; /* bits 31:14 used for 16K window */
		mch_window = ioremap_nocache(mchbar, 0x1000);
		if (!mch_window) {
		edac_dbg(3, "error ioremapping MCHBAR!\n");
		goto fail0;
		}

		#ifdef i82975x_DEBUG_IOMEM
		i82975x_printk(KERN_INFO, "MCHBAR real = %0x, remapped = %p\n",

Admin message