Commit 1fd224e3 authored Jan 13, 2020 by Paul Cercueil Committed by Thomas Gleixner Jan 13, 2020

irqchip/ingenic: Get rid of the legacy IRQ domain

Get rid of the legacy IRQ domain and hardcoded IRQ base, since all the
Ingenic drivers and platform code have been updated to use devicetree.

This also fixes the kernel being flooded with messages like:

irq: interrupt-controller@10001000 didn't like hwirq-0x0 to VIRQ8 mapping (rc=-19)

Fixes: 8bc7464b ("irqchip: ingenic: Alloc generic chips from IRQ domain").
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
Tested-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
Acked-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20200113163329.34282-2-paul@crapouillou.net

parent b3a987b0

drivers/irqchip/irq-ingenic.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -17,7 +17,6 @@
		#include <linux/delay.h>

		#include <asm/io.h>
		#include <asm/mach-jz4740/irq.h>

		struct ingenic_intc_data {
		void __iomem *base;
		@@ -50,7 +49,7 @@ static irqreturn_t intc_cascade(int irq, void *data)
		while (pending) {
		int bit = __fls(pending);

		irq = irq_find_mapping(domain, bit + (i * 32));
		irq = irq_linear_revmap(domain, bit + (i * 32));
		generic_handle_irq(irq);
		pending &= ~BIT(bit);
		}
		@@ -97,8 +96,7 @@ static int __init ingenic_intc_of_init(struct device_node *node,
		goto out_unmap_irq;
		}

		domain = irq_domain_add_legacy(node, num_chips * 32,
		JZ4740_IRQ_BASE, 0,
		domain = irq_domain_add_linear(node, num_chips * 32,
		&irq_generic_chip_ops, NULL);
		if (!domain) {
		err = -ENOMEM;