Commit 1d84353d authored Apr 01, 2019 by Kangjie Lu Committed by Bartlomiej Zolnierkiewicz Apr 01, 2019

video: imsttfb: fix potential NULL pointer dereferences



In case ioremap fails, the fix releases resources and returns
-ENOMEM to avoid NULL pointer dereferences.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Cc: Aditya Pakki <pakki001@umn.edu>
Cc: Finn Thain <fthain@telegraphics.com.au>
Cc: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[b.zolnierkie: minor patch summary fixup]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

parent ec7f6aad

drivers/video/fbdev/imsttfb.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -1515,6 +1515,11 @@ static int imsttfb_probe(struct pci_dev pdev, const struct pci_device_id ent)
		info->fix.smem_start = addr;
		info->screen_base = (__u8 *)ioremap(addr, par->ramdac == IBM ?
		0x400000 : 0x800000);
		if (!info->screen_base) {
		release_mem_region(addr, size);
		framebuffer_release(info);
		return -ENOMEM;
		}
		info->fix.mmio_start = addr + 0x800000;
		par->dc_regs = ioremap(addr + 0x800000, 0x1000);
		par->cmap_regs_phys = addr + 0x840000;

Admin message