Commit ec7f6aad authored Apr 01, 2019 by Kangjie Lu Committed by Bartlomiej Zolnierkiewicz Apr 01, 2019

video: hgafb: fix potential NULL pointer dereference

When ioremap fails, hga_vram should not be dereferenced. The fix
check the failure to avoid NULL pointer dereference.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Cc: Aditya Pakki <pakki001@umn.edu>
Cc: Ferenc Bakonyi <fero@drama.obuda.kando.hu>
[b.zolnierkie: minor patch summary fixup]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

parent b0e999c9

drivers/video/fbdev/hgafb.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -285,6 +285,8 @@ static int hga_card_detect(void)
		hga_vram_len = 0x08000;

		hga_vram = ioremap(0xb0000, hga_vram_len);
		if (!hga_vram)
		goto error;

		if (request_region(0x3b0, 12, "hgafb"))
		release_io_ports = 1;

Admin message