Commit 1ca47431 authored Nov 02, 2020 by Colin Ian King Committed by Jakub Kicinski Nov 03, 2020

net: dev_ioctl: remove redundant initialization of variable err



The variable err is being initialized with a value that is never read
and it is being updated later with a new value.  The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20201102121615.695196-1-colin.king@canonical.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 4c4ac831

net/core/dev_ioctl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -230,7 +230,7 @@ static int dev_do_ioctl(struct net_device *dev,
		struct ifreq *ifr, unsigned int cmd)
		{
		const struct net_device_ops *ops = dev->netdev_ops;
		int err = -EOPNOTSUPP;
		int err;

		err = dsa_ndo_do_ioctl(dev, ifr, cmd);
		if (err == 0 \|\| err != -EOPNOTSUPP)

Admin message