Commit 4c4ac831 authored Nov 02, 2020 by kernel test robot Committed by Jakub Kicinski Nov 03, 2020

forcedeth: fix excluded_middle.cocci warnings



Condition !A || A && B is equivalent to !A || B.

Generated by: scripts/coccinelle/misc/excluded_middle.cocci

Fixes: b76f0ea0 ("coccinelle: misc: add excluded_middle.cocci script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Link: https://lore.kernel.org/r/alpine.DEB.2.22.394.2011020936100.3077@hadrien


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 74d155be

drivers/net/ethernet/nvidia/forcedeth.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1043,8 +1043,7 @@ static int using_multi_irqs(struct net_device *dev)
		struct fe_priv *np = get_nvpriv(dev);

		if (!(np->msi_flags & NV_MSI_X_ENABLED) \|\|
		((np->msi_flags & NV_MSI_X_ENABLED) &&
		((np->msi_flags & NV_MSI_X_VECTORS_MASK) == 0x1)))
		((np->msi_flags & NV_MSI_X_VECTORS_MASK) == 0x1))
		return 0;
		else
		return 1;

Admin message