Commit 1ad24058 authored Jul 18, 2020 by Karsten Graul Committed by David S. Miller Jul 19, 2020

net/smc: fix restoring of fallback changes



When a listen socket is closed then all non-accepted sockets in its
accept queue are to be released. Inside __smc_release() the helper
smc_restore_fallback_changes() restores the changes done to the socket
without to check if the clcsocket has a file set. This can result in
a crash. Fix this by checking the file pointer first.

Reviewed-by: Ursula Braun <ubraun@linux.ibm.com>
Fixes: f536dffc ("net/smc: fix closing of fallback SMC sockets")
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent fd7f3a74

net/smc/af_smc.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -126,9 +126,11 @@ EXPORT_SYMBOL_GPL(smc_proto6);

		static void smc_restore_fallback_changes(struct smc_sock *smc)
		{
		if (smc->clcsock->file) { /* non-accepted sockets have no file yet */
		smc->clcsock->file->private_data = smc->sk.sk_socket;
		smc->clcsock->file = NULL;
		}
		}

		static int __smc_release(struct smc_sock *smc)
		{

Admin message