Commit fd7f3a74 authored Jul 18, 2020 by Karsten Graul Committed by David S. Miller Jul 19, 2020

net/smc: remove freed buffer from list



Two buffers are allocated for each SMC connection. Each buffer is
added to a buffer list after creation. When the second buffer
allocation fails, the first buffer is freed but not deleted from
the list. This might result in crashes when another connection picks
up the freed buffer later and starts to work with it.

Reviewed-by: Ursula Braun <ubraun@linux.ibm.com>
Fixes: 6511aad3 ("net/smc: change smc_buf_free function parameters")
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 741a49a4

net/smc/smc_core.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -1772,8 +1772,12 @@ int smc_buf_create(struct smc_sock *smc, bool is_smcd)
		return rc;
		/* create rmb */
		rc = __smc_buf_create(smc, is_smcd, true);
		if (rc)
		if (rc) {
		mutex_lock(&smc->conn.lgr->sndbufs_lock);
		list_del(&smc->conn.sndbuf_desc->list);
		mutex_unlock(&smc->conn.lgr->sndbufs_lock);
		smc_buf_free(smc->conn.lgr, false, smc->conn.sndbuf_desc);
		}
		return rc;
		}

Admin message