Commit 1a982620 authored Jul 01, 2020 by Bob Liu Committed by Martin K. Petersen Jul 02, 2020

scsi: iscsi: Change iSCSI workqueue max_active back to 1

Commit 3ce41966 ("scsi: iscsi: Register sysfs for iscsi workqueue")
enabled 'cpumask' support for iSCSI workqueues. However, it is unnecessary
to set max_active = 2 since 'cpumask' can still be modified when max_active
is 1.

This patch sets max_active to 1 so as to keep the same behaviour as before.

Link: https://lore.kernel.org/r/20200701030745.16897-1-bob.liu@oracle.com


Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Bob Liu <bob.liu@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 5aee52c4

drivers/scsi/libiscsi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2629,7 +2629,7 @@ struct Scsi_Host iscsi_host_alloc(struct scsi_host_template sht,
		"iscsi_q_%d", shost->host_no);
		ihost->workq = alloc_workqueue("%s",
		WQ_SYSFS \| __WQ_LEGACY \| WQ_MEM_RECLAIM \| WQ_UNBOUND,
		2, ihost->workq_name);
		1, ihost->workq_name);
		if (!ihost->workq)
		goto free_host;
		}

drivers/scsi/scsi_transport_iscsi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4760,7 +4760,7 @@ static __init int iscsi_transport_init(void)

		iscsi_eh_timer_workq = alloc_workqueue("%s",
		WQ_SYSFS \| __WQ_LEGACY \| WQ_MEM_RECLAIM \| WQ_UNBOUND,
		2, "iscsi_eh");
		1, "iscsi_eh");
		if (!iscsi_eh_timer_workq) {
		err = -ENOMEM;
		goto release_nls;

Admin message