Commit 5aee52c4 authored Jun 27, 2020 by Tom Rix Committed by Martin K. Petersen Jun 29, 2020

scsi: scsi_transport_spi: Fix function pointer check

clang static analysis flags several null function pointer problems.

drivers/scsi/scsi_transport_spi.c:374:1: warning: Called function pointer is null (null dereference) [core.CallAndMessage]
spi_transport_max_attr(offset, "%d\n");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Reviewing the store_spi_store_max macro

	if (i->f->set_##field)
		return -EINVAL;

should be

	if (!i->f->set_##field)
		return -EINVAL;

Link: https://lore.kernel.org/r/20200627133242.21618-1-trix@redhat.com


Reviewed-by: James Bottomley <jejb@linux.ibm.com>
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 311950f8

drivers/scsi/scsi_transport_spi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -339,7 +339,7 @@ store_spi_transport_##field(struct device *dev, \
		struct spi_transport_attrs *tp \
		= (struct spi_transport_attrs *)&starget->starget_data; \
		\
		if (i->f->set_##field) \
		if (!i->f->set_##field) \
		return -EINVAL; \
		val = simple_strtoul(buf, NULL, 0); \
		if (val > tp->max_##field) \

Admin message