Commit 16b0dc29 authored Jun 10, 2012 by Eric Dumazet Committed by David S. Miller Jun 11, 2012

dummy: fix rcu_sched self-detected stalls



Trying to "modprobe dummy numdummies=30000" triggers :

INFO: rcu_sched self-detected stall on CPU { 8} (t=60000 jiffies)

After this splat, RTNL is locked and reboot is needed.

We must call cond_resched() to avoid this, even holding RTNL.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c5d21c4b

drivers/net/dummy.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -187,8 +187,10 @@ static int __init dummy_init_module(void)
		rtnl_lock();
		err = __rtnl_link_register(&dummy_link_ops);

		for (i = 0; i < numdummies && !err; i++)
		for (i = 0; i < numdummies && !err; i++) {
		err = dummy_init_one();
		cond_resched();
		}
		if (err < 0)
		__rtnl_link_unregister(&dummy_link_ops);
		rtnl_unlock();

Admin message