Commit c5d21c4b authored Jun 10, 2012 by Roland Dreier Committed by David S. Miller Jun 11, 2012

net: Reorder initialization in ip_route_output to fix gcc warning



If I build with W=1, for every file that includes <net/route.h>, I get the warning

    include/net/route.h: In function 'ip_route_output':
    include/net/route.h:135:3: warning: initialized field overwritten [-Woverride-init]
    include/net/route.h:135:3: warning: (near initialization for 'fl4') [-Woverride-init]

(This is with "gcc (Debian 4.6.3-1) 4.6.3")

A fix seems pretty trivial: move the initialization of .flowi4_tos
earlier.  As far as I can tell, this has no effect on code generation.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 83a27052

include/net/route.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -130,9 +130,9 @@ static inline struct rtable ip_route_output(struct net net, __be32 daddr,
		{
		struct flowi4 fl4 = {
		.flowi4_oif = oif,
		.flowi4_tos = tos,
		.daddr = daddr,
		.saddr = saddr,
		.flowi4_tos = tos,
		};
		return ip_route_output_key(net, &fl4);
		}

Admin message