Commit 164ab90d authored Sep 14, 2020 by Srinivas Neeli Committed by Marc Kleine-Budde Oct 07, 2020

can: xilinx_can: Fix incorrect variable and initialize with a default value

Some variables with incorrect type were passed to "of_property_read_u32"
API, "of_property_read_u32" API was expecting an "u32 *" but the formal
parameter that was passed was of type "int *". Fixed the issue by
changing the variable types from "int" to "u32" and initialized with a
default value. Fixed sparse warning.

Addresses-Coverity: "incompatible_param"
Addresses-Coverity: "UNINIT(Using uninitialized value)"
Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Link: https://lore.kernel.org/r/0651544d22f3c25893ca9d445b14823f0dfddfc8.1600073396.git.michal.simek@xilinx.com

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent a61035c5

drivers/net/can/xilinx_can.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1671,7 +1671,7 @@ static int xcan_probe(struct platform_device *pdev)
		void __iomem *addr;
		int ret;
		int rx_max, tx_max;
		int hw_tx_max, hw_rx_max;
		u32 hw_tx_max = 0, hw_rx_max = 0;
		const char *hw_tx_max_property;

		/* Get the virtual base address for the device */
		@@ -1724,7 +1724,7 @@ static int xcan_probe(struct platform_device *pdev)
		*/
		if (!(devtype->flags & XCAN_FLAG_TX_MAILBOXES) &&
		(devtype->flags & XCAN_FLAG_TXFEMP))
		tx_max = min(hw_tx_max, 2);
		tx_max = min(hw_tx_max, 2U);
		else
		tx_max = 1;