Commit a61035c5 authored Sep 14, 2020 by Srinivas Neeli Committed by Marc Kleine-Budde Oct 07, 2020

can: xilinx_can: Check return value of set_reset_mode



Check return value of set_reset_mode() for error.

Addresses-Coverity: "check_return"
Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Link: https://lore.kernel.org/r/bac2c2b857986472a11db341b3f6f7a8905ad0dd.1600073396.git.michal.simek@xilinx.com


Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent 05ca14fd

drivers/net/can/xilinx_can.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -1369,9 +1369,13 @@ static irqreturn_t xcan_interrupt(int irq, void *dev_id)
		static void xcan_chip_stop(struct net_device *ndev)
		{
		struct xcan_priv *priv = netdev_priv(ndev);
		int ret;

		/* Disable interrupts and leave the can in configuration mode */
		set_reset_mode(ndev);
		ret = set_reset_mode(ndev);
		if (ret < 0)
		netdev_dbg(ndev, "set_reset_mode() Failed\n");

		priv->can.state = CAN_STATE_STOPPED;
		}

Admin message