Commit 0fa1a15f authored by Liu Yi L's avatar Liu Yi L Committed by Joerg Roedel
Browse files

iommu/vt-d: Fix devTLB flush for vSVA 



For guest SVA usage, in order to optimize for less VMEXIT, guest request
of IOTLB flush also includes device TLB.

On the host side, IOMMU driver performs IOTLB and implicit devTLB
invalidation. When PASID-selective granularity is requested by the guest
we need to derive the equivalent address range for devTLB instead of
using the address information in the UAPI data. The reason for that is,
unlike IOTLB flush, devTLB flush does not support PASID-selective
granularity. This is to say, we need to set the following in the PASID
based devTLB invalidation descriptor:
- entire 64 bit range in address ~(0x1 << 63)
- S bit = 1 (VT-d CH 6.5.2.6).

Without this fix, device TLB flush range is not set properly for PASID
selective granularity. This patch also merged devTLB flush code for both
implicit and explicit cases.

Fixes: 6ee1b77b ("iommu/vt-d: Add svm/sva invalidate function")
Signed-off-by: default avatarLiu Yi L <yi.l.liu@intel.com>
Signed-off-by: default avatarJacob Pan <jacob.jun.pan@linux.intel.com>
Signed-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: default avatarEric Auger <eric.auger@redhat.com>
Link: https://lore.kernel.org/r/20200724014925.15523-6-baolu.lu@linux.intel.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 288d08e7

drivers/iommu/intel/iommu.c

+21 −10
Original line number Diff line number Diff line
@@ -5416,7 +5416,7 @@ intel_iommu_sva_invalidate(struct iommu_domain *domain, struct device *dev, 
	sid = PCI_DEVID(bus, devfn);



	/* Size is only valid in address selective invalidation */

	if (inv_info->granularity != IOMMU_INV_GRANU_PASID)

	if (inv_info->granularity == IOMMU_INV_GRANU_ADDR)

		size = to_vtd_size(inv_info->addr_info.granule_size,

				   inv_info->addr_info.nb_granules);
@@ -5425,6 +5425,7 @@ intel_iommu_sva_invalidate(struct iommu_domain *domain, struct device *dev, 
			 IOMMU_CACHE_INV_TYPE_NR) {

		int granu = 0;

		u64 pasid = 0;

		u64 addr = 0;



		granu = to_vtd_granularity(cache_type, inv_info->granularity);

		if (granu == -EINVAL) {
@@ -5464,24 +5465,34 @@ intel_iommu_sva_invalidate(struct iommu_domain *domain, struct device *dev, 
					(granu == QI_GRAN_NONG_PASID) ? -1 : 1 << size,

					inv_info->addr_info.flags & IOMMU_INV_ADDR_FLAGS_LEAF);



			if (!info->ats_enabled)

				break;

			/*

			 * Always flush device IOTLB if ATS is enabled. vIOMMU

			 * in the guest may assume IOTLB flush is inclusive,

			 * which is more efficient.

			 */

			if (info->ats_enabled)

				qi_flush_dev_iotlb_pasid(iommu, sid,

						info->pfsid, pasid,

						info->ats_qdep,

						inv_info->addr_info.addr,

						size);

			break;

			fallthrough;

		case IOMMU_CACHE_INV_TYPE_DEV_IOTLB:

			/*

			 * PASID based device TLB invalidation does not support

			 * IOMMU_INV_GRANU_PASID granularity but only supports

			 * IOMMU_INV_GRANU_ADDR.

			 * The equivalent of that is we set the size to be the

			 * entire range of 64 bit. User only provides PASID info

			 * without address info. So we set addr to 0.

			 */

			if (inv_info->granularity == IOMMU_INV_GRANU_PASID) {

				size = 64 - VTD_PAGE_SHIFT;

				addr = 0;

			} else if (inv_info->granularity == IOMMU_INV_GRANU_ADDR) {

				addr = inv_info->addr_info.addr;

			}



			if (info->ats_enabled)

				qi_flush_dev_iotlb_pasid(iommu, sid,

						info->pfsid, pasid,

						info->ats_qdep,

						inv_info->addr_info.addr,

						info->ats_qdep, addr,

						size);

			else

				pr_warn_ratelimited("Passdown device IOTLB flush w/o ATS!\n");

CRA Git | Maintained and supported by SUSTech CRA and CCSE