Commit 0b9aefea authored Apr 01, 2017 by Marcelo Ricardo Leitner Committed by David S. Miller Apr 03, 2017

tcp: minimize false-positives on TCP/GRO check



Markus Trippelsdorf reported that after commit dcb17d22 ("tcp: warn
on bogus MSS and try to amend it") the kernel started logging the
warning for a NIC driver that doesn't even support GRO.

It was diagnosed that it was possibly caused on connections that were
using TCP Timestamps but some packets lacked the Timestamps option. As
we reduce rcv_mss when timestamps are used, the lack of them would cause
the packets to be bigger than expected, although this is a valid case.

As this warning is more as a hint, getting a clean-cut on the
threshold is probably not worth the execution time spent on it. This
patch thus alleviates the false-positives with 2 quick checks: by
accounting for the entire TCP option space and also checking against the
interface MTU if it's available.

These changes, specially the MTU one, might mask some real positives,
though if they are really happening, it's possible that sooner or later
it will be triggered anyway.

Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent df2729c3

net/ipv4/tcp_input.c

+9 −5

Original line number	Diff line number	Diff line
		@@ -126,7 +126,8 @@ int sysctl_tcp_invalid_ratelimit __read_mostly = HZ/2;
		#define REXMIT_LOST 1 /* retransmit packets marked lost */
		#define REXMIT_NEW 2 /* FRTO-style transmit of unsent/new packets */

		static void tcp_gro_dev_warn(struct sock sk, const struct sk_buff skb)
		static void tcp_gro_dev_warn(struct sock sk, const struct sk_buff skb,
		unsigned int len)
		{
		static bool __once __read_mostly;

		@@ -137,6 +138,7 @@ static void tcp_gro_dev_warn(struct sock sk, const struct sk_buff skb)

		rcu_read_lock();
		dev = dev_get_by_index_rcu(sock_net(sk), skb->skb_iif);
		if (!dev \|\| len >= dev->mtu)
		pr_warn("%s: Driver has suspect GRO implementation, TCP performance may be compromised.\n",
		dev ? dev->name : "Unknown driver");
		rcu_read_unlock();
		@@ -161,8 +163,10 @@ static void tcp_measure_rcv_mss(struct sock sk, const struct sk_buff skb)
		if (len >= icsk->icsk_ack.rcv_mss) {
		icsk->icsk_ack.rcv_mss = min_t(unsigned int, len,
		tcp_sk(sk)->advmss);
		if (unlikely(icsk->icsk_ack.rcv_mss != len))
		tcp_gro_dev_warn(sk, skb);
		/* Account for possibly-removed options */
		if (unlikely(len > icsk->icsk_ack.rcv_mss +
		MAX_TCP_OPTION_SPACE))
		tcp_gro_dev_warn(sk, skb, len);
		} else {
		/* Otherwise, we make more careful check taking into account,
		* that SACKs block is variable.

Admin message