Commit dcb17d22 authored Dec 05, 2016 by Marcelo Ricardo Leitner Committed by David S. Miller Dec 06, 2016

tcp: warn on bogus MSS and try to amend it



There have been some reports lately about TCP connection stalls caused
by NIC drivers that aren't setting gso_size on aggregated packets on rx
path. This causes TCP to assume that the MSS is actually the size of the
aggregated packet, which is invalid.

Although the proper fix is to be done at each driver, it's often hard
and cumbersome for one to debug, come to such root cause and report/fix
it.

This patch amends this situation in two ways. First, it adds a warning
on when this situation occurs, so it gives a hint to those trying to
debug this. It also limit the maximum probed MSS to the adverised MSS,
as it should never be any higher than that.

The result is that the connection may not have the best performance ever
but it shouldn't stall, and the admin will have a hint on what to look
for.

Tested with virtio by forcing gso_size to 0.

v2: updated msg per David's suggestion
v3: use skb_iif to find the interface and also log its name, per Eric
    Dumazet's suggestion. As the skb may be backlogged and the interface
    gone by then, we need to check if the number still has a meaning.
v4: use helper tcp_gro_dev_warn() and avoid pr_warn_once inside __once, per
    David's suggestion

Cc: Jonathan Maxwell <jmaxwell37@gmail.com>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent efc45154

net/ipv4/tcp_input.c

+21 −1

Original line number	Diff line number	Diff line
		@@ -128,6 +128,23 @@ int sysctl_tcp_invalid_ratelimit __read_mostly = HZ/2;
		#define REXMIT_LOST 1 /* retransmit packets marked lost */
		#define REXMIT_NEW 2 /* FRTO-style transmit of unsent/new packets */

		static void tcp_gro_dev_warn(struct sock sk, const struct sk_buff skb)
		{
		static bool __once __read_mostly;

		if (!__once) {
		struct net_device *dev;

		__once = true;

		rcu_read_lock();
		dev = dev_get_by_index_rcu(sock_net(sk), skb->skb_iif);
		pr_warn("%s: Driver has suspect GRO implementation, TCP performance may be compromised.\n",
		dev ? dev->name : "Unknown driver");
		rcu_read_unlock();
		}
		}

		/* Adapt the MSS value used to make delayed ack decision to the
		* real world.
		*/
		@@ -144,7 +161,10 @@ static void tcp_measure_rcv_mss(struct sock sk, const struct sk_buff skb)
		*/
		len = skb_shinfo(skb)->gso_size ? : skb->len;
		if (len >= icsk->icsk_ack.rcv_mss) {
		icsk->icsk_ack.rcv_mss = len;
		icsk->icsk_ack.rcv_mss = min_t(unsigned int, len,
		tcp_sk(sk)->advmss);
		if (unlikely(icsk->icsk_ack.rcv_mss != len))
		tcp_gro_dev_warn(sk, skb);
		} else {
		/* Otherwise, we make more careful check taking into account,
		* that SACKs block is variable.

Admin message