Commit 0b91111f authored Jun 18, 2020 by Loic Poulain Committed by Johannes Berg Aug 03, 2020

mac80211: Do not report beacon loss if beacon filtering enabled



mac80211.h says: Beacon filter support is advertised with the
IEEE80211_VIF_BEACON_FILTER interface capability. The driver needs to
enable beacon filter support whenever power save is enabled, that is
IEEE80211_CONF_PS is set. When power save is enabled, the stack will
not check for beacon loss and the driver needs to notify about loss
of beacons with ieee80211_beacon_loss().

Some controllers may want to dynamically enable the beacon filter
capabilities on power save entry (CONF_PS) and disable it on exit.
This is the case for the wcn36xx driver which only supports beacon
filtering in PS mode (no CONNECTION_MONITOR support).

When the mac80211 beacon monitor timer expires, the beacon filter
flag must be checked again in case it as been changed in between
(e.g. vif moved to PS mode).

Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Link: https://lore.kernel.org/r/1592471863-31402-1-git-send-email-loic.poulain@linaro.org


Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 5981fe5b

net/mac80211/mlme.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -4563,6 +4563,9 @@ static void ieee80211_sta_bcn_mon_timer(struct timer_list *t)
		if (sdata->vif.csa_active && !ifmgd->csa_waiting_bcn)
		return;

		if (sdata->vif.driver_flags & IEEE80211_VIF_BEACON_FILTER)
		return;

		sdata->u.mgd.connection_loss = false;
		ieee80211_queue_work(&sdata->local->hw,
		&sdata->u.mgd.beacon_connection_loss_work);

Admin message