Commit 5981fe5b authored Aug 03, 2020 by Johannes Berg

mac80211: fix misplaced while instead of if



This never was intended to be a 'while' loop, it should've
just been an 'if' instead of 'while'. Fix this.

I noticed this while applying another patch from Ben that
intended to fix a busy loop at this spot.

Cc: stable@vger.kernel.org
Fixes: b16798f5 ("mac80211: mark station unauthorized before key removal")
Reported-by: Ben Greear <greearb@candelatech.com>
Link: https://lore.kernel.org/r/20200803110209.253009ae41ff.I3522aad099392b31d5cf2dcca34cbac7e5832dde@changeid


Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 3b1648f1

net/mac80211/sta_info.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1050,7 +1050,7 @@ static void __sta_info_destroy_part2(struct sta_info *sta)
		might_sleep();
		lockdep_assert_held(&local->sta_mtx);

		while (sta->sta_state == IEEE80211_STA_AUTHORIZED) {
		if (sta->sta_state == IEEE80211_STA_AUTHORIZED) {
		ret = sta_info_move_state(sta, IEEE80211_STA_ASSOC);
		WARN_ON_ONCE(ret);
		}

Admin message