mtd: rawnand: qcom: Stop using nand_release() (0a2bc991) · Commits · 戴 / test

This helper is not very useful and very often people get confused: they use nand_release() instead of nand_cleanup(). Let's stop using nand_release() by calling mtd_device_unregister() and nand_cleanup() directly. Signed-off-by:

Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-45-miquel.raynal@bootlin.com

drivers/mtd/nand/raw/qcom_nandc.c

+8 −3

Original line number	Diff line number	Diff line
		@@ -3005,10 +3005,15 @@ static int qcom_nandc_remove(struct platform_device *pdev)
		struct qcom_nand_controller *nandc = platform_get_drvdata(pdev);
		struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		struct qcom_nand_host *host;
		struct nand_chip *chip;
		int ret;

		list_for_each_entry(host, &nandc->host_list, node)
		nand_release(&host->chip);

		list_for_each_entry(host, &nandc->host_list, node) {
		chip = &host->chip;
		ret = mtd_device_unregister(nand_to_mtd(chip));
		WARN_ON(ret);
		nand_cleanup(chip);
		}

		qcom_nandc_unalloc(nandc);

Admin message