Commit d1aae005 authored May 19, 2020 by Miquel Raynal

mtd: rawnand: plat_nand: Stop using nand_release()



This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().

Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-44-miquel.raynal@bootlin.com

parent 5284024b

drivers/mtd/nand/raw/plat_nand.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -106,8 +106,12 @@ static int plat_nand_remove(struct platform_device *pdev)
		{
		struct plat_nand_data *data = platform_get_drvdata(pdev);
		struct platform_nand_data *pdata = dev_get_platdata(&pdev->dev);
		struct nand_chip *chip = &data->chip;
		int ret;

		nand_release(&data->chip);
		ret = mtd_device_unregister(nand_to_mtd(chip));
		WARN_ON(ret);
		nand_cleanup(chip);
		if (pdata->ctrl.remove)
		pdata->ctrl.remove(pdev);

Admin message