Commit 05a08796 authored Apr 09, 2020 by Colin Ian King Committed by Ingo Molnar Apr 14, 2020

efi/libstub/x86: Remove redundant assignment to pointer hdr



The pointer hdr is being assigned a value that is never read and
it is being updated later with a new value. The assignment is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20200402102537.503103-1-colin.king@canonical.com
Link: https://lore.kernel.org/r/20200409130434.6736-3-ardb@kernel.org

parent b450b30b

drivers/firmware/efi/libstub/x86-stub.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -392,8 +392,6 @@ efi_status_t __efiapi efi_pe_entry(efi_handle_t handle,
		image_base = efi_table_attr(image, image_base);
		image_offset = (void *)startup_32 - image_base;

		hdr = &((struct boot_params *)image_base)->hdr;

		status = efi_allocate_pages(0x4000, (unsigned long *)&boot_params, ULONG_MAX);
		if (status != EFI_SUCCESS) {
		efi_printk("Failed to allocate lowmem for boot params\n");

Admin message