Commit b450b30b authored Apr 09, 2020 by Takashi Iwai Committed by Ingo Molnar Apr 14, 2020

efi/cper: Use scnprintf() for avoiding potential buffer overflow



Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit.  Fix it by replacing with scnprintf().

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20200311072145.5001-1-tiwai@suse.de
Link: https://lore.kernel.org/r/20200409130434.6736-2-ardb@kernel.org

parent 8f3d9f35

drivers/firmware/efi/cper.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -101,7 +101,7 @@ void cper_print_bits(const char *pfx, unsigned int bits,
		if (!len)
		len = snprintf(buf, sizeof(buf), "%s%s", pfx, str);
		else
		len += snprintf(buf+len, sizeof(buf)-len, ", %s", str);
		len += scnprintf(buf+len, sizeof(buf)-len, ", %s", str);
		}
		if (len)
		printk("%s\n", buf);

Admin message