ipv4: optimize route adding on secondary promotion (04024b93) · Commits · 戴 / test

Optimize the calling of fib_add_ifaddr for all secondary addresses after the promoted one to start from their place, not from the new place of the promoted secondary. It will save some CPU cycles because we are sure the promoted secondary was first for the subnet and all next secondaries do not change their place. Signed-off-by:

Julian Anastasov <ja@ssi.bg> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/ipv4/devinet.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -375,6 +375,7 @@ static void __inet_del_ifa(struct in_device in_dev, struct in_ifaddr *ifap,
		blocking_notifier_call_chain(&inetaddr_chain, NETDEV_DOWN, ifa1);

		if (promote) {
		struct in_ifaddr *next_sec = promote->ifa_next;

		if (prev_prom) {
		prev_prom->ifa_next = promote->ifa_next;
		@@ -386,7 +387,7 @@ static void __inet_del_ifa(struct in_device in_dev, struct in_ifaddr *ifap,
		rtmsg_ifa(RTM_NEWADDR, promote, nlh, pid);
		blocking_notifier_call_chain(&inetaddr_chain,
		NETDEV_UP, promote);
		for (ifa = promote->ifa_next; ifa; ifa = ifa->ifa_next) {
		for (ifa = next_sec; ifa; ifa = ifa->ifa_next) {
		if (ifa1->ifa_mask != ifa->ifa_mask \|\|
		!inet_ifa_match(ifa1->ifa_address, ifa))
		continue;

Admin message