Commit 2d230e2b authored Mar 19, 2011 by Julian Anastasov Committed by David S. Miller Mar 22, 2011

ipv4: remove the routes on secondary promotion



The secondary address promotion relies on fib_sync_down_addr
to remove all routes created for the secondary addresses when
the old primary address is deleted. It does not happen for cases
when the primary address is also in another subnet. Fix that
by deleting local and broadcast routes for all secondaries while
they are on device list and by faking that all addresses from
this subnet are to be deleted. It relies on fib_del_ifaddr being
able to ignore the IPs from the concerned subnet while checking
for duplication.

Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e6abbaa2

net/ipv4/devinet.c

+11 −0

Original line number	Diff line number	Diff line
		@@ -345,6 +345,17 @@ static void __inet_del_ifa(struct in_device in_dev, struct in_ifaddr *ifap,
		}
		}

		/* On promotion all secondaries from subnet are changing
		* the primary IP, we must remove all their routes silently
		* and later to add them back with new prefsrc. Do this
		* while all addresses are on the device list.
		*/
		for (ifa = promote; ifa; ifa = ifa->ifa_next) {
		if (ifa1->ifa_mask == ifa->ifa_mask &&
		inet_ifa_match(ifa1->ifa_address, ifa))
		fib_del_ifaddr(ifa, ifa1);
		}

		/* 2. Unlink it */

		*ifap = ifa1->ifa_next;

Admin message