Commit 037e910b authored May 25, 2020 by Xiyu Yang Committed by J. Bruce Fields May 28, 2020

SUNRPC: Remove unreachable error condition in rpcb_getport_async()



rpcb_getport_async() invokes rpcb_call_async(), which return the value
of rpc_run_task() to "child". Since rpc_run_task() is impossible to
return an ERR pointer, there is no need to add the IS_ERR() condition on
"child" here. So we need to remove it.

Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

parent a4abc6b1

net/sunrpc/rpcb_clnt.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -795,12 +795,6 @@ void rpcb_getport_async(struct rpc_task *task)

		child = rpcb_call_async(rpcb_clnt, map, proc);
		rpc_release_client(rpcb_clnt);
		if (IS_ERR(child)) {
		/* rpcb_map_release() has freed the arguments */
		dprintk("RPC: %5u %s: rpc_run_task failed\n",
		task->tk_pid, __func__);
		return;
		}

		xprt->stat.bind_count++;
		rpc_put_task(child);

Admin message