Commit a4abc6b1 authored May 25, 2020 by Xiyu Yang Committed by J. Bruce Fields May 28, 2020

nfsd: Fix svc_xprt refcnt leak when setup callback client failed



nfsd4_process_cb_update() invokes svc_xprt_get(), which increases the
refcount of the "c->cn_xprt".

The reference counting issue happens in one exception handling path of
nfsd4_process_cb_update(). When setup callback client failed, the
function forgets to decrease the refcnt increased by svc_xprt_get(),
causing a refcnt leak.

Fix this issue by calling svc_xprt_put() when setup callback client
failed.

Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

parent 24c5efe4

fs/nfsd/nfs4callback.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1306,6 +1306,8 @@ static void nfsd4_process_cb_update(struct nfsd4_callback *cb)
		err = setup_callback_client(clp, &conn, ses);
		if (err) {
		nfsd4_mark_cb_down(clp, err);
		if (c)
		svc_xprt_put(c->cn_xprt);
		return;
		}
		}

Admin message