Commit 036dfd83 authored Oct 06, 2020 by Matthieu Baerts Committed by Jakub Kicinski Oct 08, 2020

selftests: mptcp: interpret \n as a new line



In case of errors, this message was printed:

  (...)
  balanced bwidth with unbalanced delay       5233 max 5005  [ fail ]
  client exit code 0, server 0
  \nnetns ns3-0-EwnkPH socket stat for 10003:
  (...)

Obviously, the idea was to add a new line before the socket stat and not
print "\nnetns".

The commit 8b974778 ("selftests: mptcp: interpret \n as a new line")
is very similar to this one. But the modification in simult_flows.sh was
missed because this commit above was done in parallel to one here below.

Fixes: 1a418cb8 ("mptcp: simult flow self-tests")
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent de997e54

tools/testing/selftests/net/mptcp/simult_flows.sh

+2 −2

Original line number	Diff line number	Diff line
		@@ -200,9 +200,9 @@ do_transfer()

		echo " [ fail ]"
		echo "client exit code $retc, server $rets" 1>&2
		echo "\nnetns ${ns3} socket stat for $port:" 1>&2
		echo -e "\nnetns ${ns3} socket stat for $port:" 1>&2
		ip netns exec ${ns3} ss -nita 1>&2 -o "sport = :$port"
		echo "\nnetns ${ns1} socket stat for $port:" 1>&2
		echo -e "\nnetns ${ns1} socket stat for $port:" 1>&2
		ip netns exec ${ns1} ss -nita 1>&2 -o "dport = :$port"
		ls -l $sin $cout
		ls -l $cin $sout

Admin message