Commit 8b974778 authored by Matthieu Baerts's avatar Matthieu Baerts Committed by David S. Miller
Browse files

selftests: mptcp: interpret \n as a new line 



In case of errors, this message was printed:

  (...)
  # read: Resource temporarily unavailable
  #  client exit code 0, server 3
  # \nnetns ns1-0-BJlt5D socket stat for 10003:
  (...)

Obviously, the idea was to add a new line before the socket stat and not
print "\nnetns".

Fixes: b08fbf24 ("selftests: add test-cases for MPTCP MP_JOIN")
Fixes: 048d19d4 ("mptcp: add basic kselftest for mptcp")
Signed-off-by: default avatarMatthieu Baerts <matthieu.baerts@tessares.net>
Acked-by: default avatarPaolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b79a80bd

tools/testing/selftests/net/mptcp/mptcp_connect.sh

+2 −2
Original line number Diff line number Diff line
@@ -443,9 +443,9 @@ do_transfer() 
	duration=$(printf "(duration %05sms)" $duration)

	if [ ${rets} -ne 0 ] || [ ${retc} -ne 0 ]; then

		echo "$duration [ FAIL ] client exit code $retc, server $rets" 1>&2

		echo "\nnetns ${listener_ns} socket stat for $port:" 1>&2

		echo -e "\nnetns ${listener_ns} socket stat for ${port}:" 1>&2

		ip netns exec ${listener_ns} ss -nita 1>&2 -o "sport = :$port"

		echo "\nnetns ${connector_ns} socket stat for $port:" 1>&2

		echo -e "\nnetns ${connector_ns} socket stat for ${port}:" 1>&2

		ip netns exec ${connector_ns} ss -nita 1>&2 -o "dport = :$port"



		cat "$capout"

tools/testing/selftests/net/mptcp/mptcp_join.sh

+2 −2
Original line number Diff line number Diff line
@@ -176,9 +176,9 @@ do_transfer() 


	if [ ${rets} -ne 0 ] || [ ${retc} -ne 0 ]; then

		echo " client exit code $retc, server $rets" 1>&2

		echo "\nnetns ${listener_ns} socket stat for $port:" 1>&2

		echo -e "\nnetns ${listener_ns} socket stat for ${port}:" 1>&2

		ip netns exec ${listener_ns} ss -nita 1>&2 -o "sport = :$port"

		echo "\nnetns ${connector_ns} socket stat for $port:" 1>&2

		echo -e "\nnetns ${connector_ns} socket stat for ${port}:" 1>&2

		ip netns exec ${connector_ns} ss -nita 1>&2 -o "dport = :$port"



		cat "$capout"

CRA Git | Maintained and supported by SUSTech CRA and CCSE