Commit 00203737 authored Sep 27, 2020 by Krzysztof Kozlowski Committed by Shawn Guo Oct 30, 2020

arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up



The PMIC's interrupt is level low and should be pulled up.  The PMIC's
device node had pinctrl-0 property but it lacked pinctrl-names which
is required to apply the pin configuration.  The actual problem in DTS
was pointed out by Felix Radensky from Variscite.

Reported-by: Felix Radensky <felix.r@variscite.com>
Fixes: 5f67317b ("arm64: dts: imx8mm: correct interrupt flags")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Robin Gong <yibin.gong@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>

parent ccee91b5

arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi

+3 −6

Original line number	Diff line number	Diff line
		@@ -135,13 +135,10 @@
		pmic@4b {
		compatible = "rohm,bd71847";
		reg = <0x4b>;
		pinctrl-names = "default";
		pinctrl-0 = <&pinctrl_pmic>;
		interrupt-parent = <&gpio2>;
		/*
		* The interrupt is not correct. It should be level low,
		* however with internal pull up this causes IRQ storm.
		*/
		interrupts = <8 IRQ_TYPE_EDGE_RISING>;
		interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
		rohm,reset-snvs-powered;

		#clock-cells = <0>;
		@@ -398,7 +395,7 @@

		pinctrl_pmic: pmicirqgrp {
		fsl,pins = <
		MX8MM_IOMUXC_SD1_DATA6_GPIO2_IO8 0x41
		MX8MM_IOMUXC_SD1_DATA6_GPIO2_IO8 0x141
		>;
		};

Admin message