Commit 00147449 authored by Woodruff, Richard's avatar Woodruff, Richard Committed by Thomas Gleixner
Browse files

nohz: suppress needless timer reprogramming 



In my device I get many interrupts from a high speed USB device in a very
short period of time.  The system spends a lot of time reprogramming the
hardware timer which is in a slower timing domain as compared to the CPU. 
This results in the CPU spending a huge amount of time waiting for the
timer posting to be done.  All of this reprogramming is useless as the
wake up time has not changed.

As measured using ETM trace this drops my reprogramming penalty from
almost 60% CPU load down to 15% during high interrupt rate.  I can send
traces to show this.

Suppress setting of duplicate timer event when timer already stopped. 
Timer programming can be very costly and can result in long cpu stall/wait
times.

[akpm@linux-foundation.org: coding-style fixes]
[tglx@linutronix.de: move the check to the right place and avoid raising
		     the softirq for nothing]

Signed-off-by: default avatarRichard Woodruff <r-woodruff2@ti.com>
Cc: johnstul@us.ibm.com
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent fa116ea3

kernel/time/tick-sched.c

+24 −17
Original line number Diff line number Diff line
@@ -282,8 +282,31 @@ void tick_nohz_stop_sched_tick(int inidle) 
	/* Schedule the tick, if we are at least one jiffie off */

	if ((long)delta_jiffies >= 1) {



		/*

		* calculate the expiry time for the next timer wheel

		* timer

		*/

		expires = ktime_add_ns(last_update, tick_period.tv64 *

				   delta_jiffies);



		/*

		 * If this cpu is the one which updates jiffies, then

		 * give up the assignment and let it be taken by the

		 * cpu which runs the tick timer next, which might be

		 * this cpu as well. If we don't drop this here the

		 * jiffies might be stale and do_timer() never

		 * invoked.

		 */

		if (cpu == tick_do_timer_cpu)

			tick_do_timer_cpu = TICK_DO_TIMER_NONE;



		if (delta_jiffies > 1)

			cpu_set(cpu, nohz_cpu_mask);



		/* Skip reprogram of event if its not changed */

		if (ts->tick_stopped && ktime_equal(expires, dev->next_event))

			goto out;



		/*

		 * nohz_stop_sched_tick can be called several times before

		 * the nohz_restart_sched_tick is called. This happens when
@@ -306,17 +329,6 @@ void tick_nohz_stop_sched_tick(int inidle) 
			rcu_enter_nohz();

		}



		/*

		 * If this cpu is the one which updates jiffies, then

		 * give up the assignment and let it be taken by the

		 * cpu which runs the tick timer next, which might be

		 * this cpu as well. If we don't drop this here the

		 * jiffies might be stale and do_timer() never

		 * invoked.

		 */

		if (cpu == tick_do_timer_cpu)

			tick_do_timer_cpu = TICK_DO_TIMER_NONE;



		ts->idle_sleeps++;



		/*
@@ -332,12 +344,7 @@ void tick_nohz_stop_sched_tick(int inidle) 
			goto out;

		}



		/*

		 * calculate the expiry time for the next timer wheel

		 * timer

		 */

		expires = ktime_add_ns(last_update, tick_period.tv64 *

				       delta_jiffies);

		/* Mark expiries */

		ts->idle_expires = expires;



		if (ts->nohz_mode == NOHZ_MODE_HIGHRES) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE