Commit fa116ea3 authored Dec 11, 2008 by Heiko Carstens Committed by Ingo Molnar Dec 12, 2008

nohz: no softirq pending warnings for offline cpus



Impact: remove false positive warning

After a cpu was taken down during cpu hotplug (read: disabled for interrupts)
it still might have pending softirqs. However take_cpu_down makes sure
that the idle task will run next instead of ksoftirqd on the taken down cpu.
The idle task will call tick_nohz_stop_sched_tick which might warn about
pending softirqs just before the cpu kills itself completely.

However the pending softirqs on the dead cpu aren't a problem because they
will be moved to an online cpu during CPU_DEAD handling.

So make sure we warn only for online cpus.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 6c34bc29

kernel/time/tick-sched.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -247,7 +247,7 @@ void tick_nohz_stop_sched_tick(int inidle)
		if (need_resched())
		goto end;

		if (unlikely(local_softirq_pending())) {
		if (unlikely(local_softirq_pending() && cpu_online(cpu))) {
		static int ratelimit;

		if (ratelimit < 10) {

Admin message