Commit f3f8af4c authored by Emil Lindqvist's avatar Emil Lindqvist Committed by Kumar Gala
Browse files

drivers: modem: ublox-sara-r4: make reset pin optional 



Remove reset pin requirement from devicetree as this
is not required for modem functionality, and is not
used in the driver anyways.

Signed-off-by: default avatarEmil Lindqvist <emil@lindq.gr>
parent 8b156dfc

drivers/modem/ublox-sara-r4.c

+6 −0
Original line number Diff line number Diff line
@@ -43,7 +43,9 @@ LOG_MODULE_REGISTER(modem_ublox_sara_r4, CONFIG_MODEM_LOG_LEVEL); 
/* pin settings */

enum mdm_control_pins {

	MDM_POWER = 0,

#if DT_INST_NODE_HAS_PROP(0, mdm_reset_gpios)

	MDM_RESET,

#endif

#if DT_INST_NODE_HAS_PROP(0, mdm_vint_gpios)

	MDM_VINT,

#endif
@@ -55,10 +57,12 @@ static struct modem_pin modem_pins[] = { 
		  DT_INST_GPIO_PIN(0, mdm_power_gpios),

		  DT_INST_GPIO_FLAGS(0, mdm_power_gpios) | GPIO_OUTPUT),



#if DT_INST_NODE_HAS_PROP(0, mdm_reset_gpios)

	/* MDM_RESET */

	MODEM_PIN(DT_INST_GPIO_LABEL(0, mdm_reset_gpios),

		  DT_INST_GPIO_PIN(0, mdm_reset_gpios),

		  DT_INST_GPIO_FLAGS(0, mdm_reset_gpios) | GPIO_OUTPUT),

#endif



#if DT_INST_NODE_HAS_PROP(0, mdm_vint_gpios)

	/* MDM_VINT */
@@ -904,8 +908,10 @@ static int pin_init(void) 
{

	LOG_INF("Setting Modem Pins");



#if DT_INST_NODE_HAS_PROP(0, mdm_reset_gpios)

	LOG_DBG("MDM_RESET_PIN -> NOT_ASSERTED");

	modem_pin_write(&mctx, MDM_RESET, MDM_RESET_NOT_ASSERTED);

#endif



	LOG_DBG("MDM_POWER_PIN -> ENABLE");

	modem_pin_write(&mctx, MDM_POWER, MDM_POWER_ENABLE);

dts/bindings/modem/ublox,sara-r4.yaml

+1 −1
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ properties: 


    mdm-reset-gpios:

      type: phandle-array

      required: true

      required: false



    mdm-vint-gpios:

      type: phandle-array

CRA Git | Maintained and supported by SUSTech CRA and CCSE