drivers: serial: nrfx_uarte: Fix use of PM_DEVICE_ISR_SAFE (c08390df) · Commits · Wenxi XU / zephyr

PM_DEVICE_ISR_SAFE shall not be used when non-asynchronous API is used because RX is disabled in suspend action and that takes relatively long time. In case of PM_DEVICE_ISR_SAFE it is done with interrupts disabled. RX is not used at all if disable-rx property is set and in that case PM_DEVICE_ISR_SAFE can be used. Added macro which determines if ISR safe mode can be used. Signed-off-by:

Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no> (cherry picked from commit )

drivers/serial/uart_nrfx_uarte.c

+13 −1

Changes for drivers/serial/uart_nrfx_uarte.c: 13 added lines, 1 removed line.
Original line number	Diff line number	Diff line
		@@ -2339,6 +2339,18 @@ static int uarte_instance_init(const struct device *dev,
		: UART_CFG_FLOW_CTRL_NONE, \
		}

		/* Macro determines if PM actions are interrupt safe. They are in case of
		* asynchronous API (except for instance in fast power domain) and non-asynchronous
		* API if RX is disabled. Macro must resolve to a literal 1 or 0.
		*/
		#define UARTE_PM_ISR_SAFE(idx) \
		COND_CODE_1(INSTANCE_IS_FAST_PD(_, /empty/, idx, _), \
		(0), \
		(COND_CODE_1(CONFIG_UART_##idx##_ASYNC, \
		(PM_DEVICE_ISR_SAFE), \
		(COND_CODE_1(UARTE_PROP(idx, disable_rx), \
		(PM_DEVICE_ISR_SAFE), (0)))))) \

		#define UART_NRF_UARTE_DEVICE(idx) \
		NRF_DT_CHECK_NODE_HAS_PINCTRL_SLEEP(UARTE(idx)); \
		UARTE_INT_DRIVEN(idx); \
		@@ -2405,7 +2417,7 @@ static int uarte_instance_init(const struct device *dev,
		} \
		\
		PM_DEVICE_DT_DEFINE(UARTE(idx), uarte_nrfx_pm_action, \
		PM_DEVICE_ISR_SAFE); \
		UARTE_PM_ISR_SAFE(idx)); \
		\
		DEVICE_DT_DEFINE(UARTE(idx), \
		uarte_##idx##_init, \

Admin message