Commit a1adced1 authored Sep 05, 2025 by Tomasz Leman Committed by Henrik Brix Andersen Sep 15, 2025

intel_adsp: ace: Remove redundant HPSRAM init from D3 restore

Remove hp_sram_init() call from boot_d3_restore() as it's redundant and
causes TLB access errors. The TLB driver's adsp_mm_restore_context()
already handles all HPSRAM power management and content restoration.

The removed code was attempting to zero memory regions that are
intentionally unmapped by the TLB driver for power optimization, causing
access to disabled TLB entries during D3→D0 transitions.

Additionally, hp_sram_init() powers up all memory banks while the TLB
restore function correctly enables only the banks that were actually
used, maintaining proper power optimization.

Current flow causes errors in simulation which revealed this incorrect
double initialization in test scenarios with minimal firmware
configurations.

Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>

parent 14184017

soc/intel/intel_adsp/ace/boot.c

+0 −4

Changes for soc/intel/intel_adsp/ace/boot.c: 0 added lines, 4 removed lines.
Original line number	Diff line number	Diff line
		@@ -43,10 +43,6 @@ __imr void boot_d3_restore(void)
		#ifdef CONFIG_ADSP_DISABLE_L2CACHE_AT_BOOT
		ADSP_L2PCFG_REG = 0;
		#endif

		extern void hp_sram_init(uint32_t memory_size);
		hp_sram_init(L2_SRAM_SIZE);

		extern void lp_sram_init(void);
		lp_sram_init();

Admin message