Commit 9e5e294e authored Jul 06, 2025 by Chris Friedt Committed by Dan Kalowsky Jul 11, 2025

lib: os: clock: fix for CID 529870

Fix for CID 529870, where Coverity found an issue where `timespec.tv_sec`
is never greater than `UINT64_MAX / NSEC_PER_SEC` (18446744073).

This is naturally true when `time_t` is only 32-bit, which is actually
never the case for any Zephyr platform aside from `native_sim/native/32`.

When `time_t` is a signed 64-bit value, at some point in the future, but
maybe not in our lifetimes, `timespec.tv_sec` could exceed 18446744073,
since `INT64_MAX > UINT64_MAX / NSEC_PER_SEC`.

We should not see coverity issues errors like this in the future, once we
have a consistent `time_t` representation across all Zephyr platforms.

Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>

parent aa7901c0

lib/os/clock.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -164,7 +164,8 @@ int z_impl_sys_clock_nanosleep(int clock_id, int flags, const struct timespec *r
		}

		/* sleep for relative time duration */
		if (unlikely(rqtp->tv_sec >= UINT64_MAX / NSEC_PER_SEC)) {
		if ((sizeof(rqtp->tv_sec) == sizeof(int64_t)) &&
		unlikely(rqtp->tv_sec >= (time_t)(UINT64_MAX / NSEC_PER_SEC))) {
		uint64_t ns = (uint64_t)k_sleep(K_SECONDS(duration.tv_sec - 1)) * NSEC_PER_MSEC;
		struct timespec rem = {
		.tv_sec = (time_t)(ns / NSEC_PER_SEC),

Admin message