net: lib: dns: Check return value of net_context_recv() (87ccb79a) · Commits · Wenxi XU / zephyr

Given that K_NO_WAIT is passed as a timeout to net_context_recv(), it's unlikely this function will return any error value. It's cheap to check, though, so do it. Coverity-CID: 170580 Signed-off-by:

Leandro Pereira <leandro.pereira@intel.com>

subsys/net/lib/dns/resolve.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -674,14 +674,19 @@ static int dns_write(struct dns_resolve_context *ctx,
		goto quit;
		}

		ret = net_context_recv(net_ctx, cb_recv, K_NO_WAIT, ctx);
		if (ret < 0) {
		NET_DBG("Couldn't receive from socket (%d)", ret);
		net_pkt_unref(pkt);
		goto quit;
		}

		if (server->family == AF_INET) {
		server_addr_len = sizeof(struct sockaddr_in);
		} else {
		server_addr_len = sizeof(struct sockaddr_in6);
		}

		net_context_recv(net_ctx, cb_recv, K_NO_WAIT, ctx);

		ret = net_context_sendto(pkt, server, server_addr_len, NULL,
		K_NO_WAIT, NULL, NULL);
		if (ret < 0) {

Admin message