gen_isr_tables: Added check of the IRQ num before accessing the vt (7191b64c) · Commits · Wenxi XU / zephyr

At its current state, the script tries to access the vector table list without checking first that the index is valid. This can cause the script to crash without a descriptive message. The index can be invalid if an IRQ number that is larger than the maximum number allowed by the SOC is used. This PR adds a check of that index, that exits with an error message if the index is invalid. Fixes #29809 Signed-off-by:

Yonatan Schachter <yonatan.schachter@gmail.com>

arch/common/gen_isr_tables.py

+6 −0

Original line number	Diff line number	Diff line
		@@ -259,6 +259,9 @@ def main():
		if param != 0:
		error("Direct irq %d declared, but has non-NULL parameter"
		% irq)
		if not 0 <= irq - offset < len(vt):
		error("IRQ %d (offset=%d) exceeds the maximum of %d" %
		(irq - offset, offset, len(vt) - 1))
		vt[irq - offset] = func
		else:
		# Regular interrupt
		@@ -302,6 +305,9 @@ def main():
		debug('IRQ_Pos = ' + str(irq1))
		table_index = irq1 - offset

		if not 0 <= table_index < len(swt):
		error("IRQ %d (offset=%d) exceeds the maximum of %d" %
		(table_index, offset, len(swt) - 1))
		if swt[table_index] != (0, spurious_handler):
		error(f"multiple registrations at table_index {table_index} for irq {irq} (0x{irq:x})"
		+ f"\nExisting handler 0x{swt[table_index][1]:x}, new handler 0x{func:x}"

Admin message