Commit 3399e061 authored Sep 25, 2024 by Kevin ORourke Committed by Anas Nashif Oct 10, 2024

shell: backend: telnet: Don't assert if connection closed

The code in shell_ops.c that calls telnet_write will assert if it
returns non-zero. For a telnet shell it's normal that the
network might disconnect unexepectedly, so that should not
trigger an assert.

Fixes #67637

Link: https://github.com/zephyrproject-rtos/zephyr/issues/67637



Signed-off-by: Kevin ORourke <kevin.orourke@ferroamp.se>

parent 9a5cd08d

subsys/shell/backends/shell_telnet.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -708,7 +708,12 @@ static int telnet_write(const struct shell_transport *transport,
		err = telnet_send(true);
		if (err != 0) {
		*cnt = length;
		return err;
		if ((err == -ENOTCONN) \|\| (err == -ENETDOWN)) {
		LOG_ERR("Network disconnected, shutting down");
		} else {
		LOG_ERR("Error %d, shutting down", err);
		}
		return 0; /* Return 0 to not trigger ASSERT in shell_ops.c */
		}
		}

Admin message