Skip to content
Commit 0c1e9c3e authored by Mike J. Chen's avatar Mike J. Chen Committed by Fabio Baltieri
Browse files

Revert "drivers: spi: mcux_flexcomm: use rxignore bit instead of dummy read."



This reverts commit a3530d6a.

This change incorrect if chip-select is via a GPIO pin,
released by spi_context_cs_control(), and not the controller
default chip-select pin that can be released using a final
FIFOWR.

When GPIO is used for chip-select control, the chip-select could
be released too soon because the transfer callback is invoked
when the last byte is put into the TX FIFO but that byte might
not yet have clocked out yet on the SPI pins. The rx part of
the transfer is really what completes the transfer so ignoring
it is incorrect.

We could try to special case and use ignore only when
spi_context_cs_control() does nothing, but since it is a very
small optimization, it doesn't seem worth the extra
complexity.

Signed-off-by: default avatarMike J. Chen <mjchen@google.com>
parent 60e5a562
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment