Commit 084bf248 authored by Yechang's avatar Yechang
Browse files

chore: remove useless code

parent b3592a81
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -4,7 +4,7 @@ import type { SubmissionFeedback } from "@prisma/client";
import { contentSchema } from "$lib/shared/feedback";


export const getFeedbackScore = async (feedback: SubmissionFeedback): Promise<number> => {
export const getFeedbackScore = (feedback: SubmissionFeedback): number => {
    const contentResult = contentSchema.safeParse(feedback.content)
    if (!contentResult.success) {
        return 0
@@ -60,7 +60,7 @@ export const fixAndCalculatePenalty = async (currentSubmissionId: number): Promi
        if (_.isNil(feedback)) {
            break
        }
        const originalScore = await getFeedbackScore(feedback)
        const originalScore = getFeedbackScore(feedback)
        const finalScore = _.max([originalScore - penaltyScore, 0]) || 0;
        if (feedback.score !== finalScore) {
            await db.$transaction(async (tx) => {
+0 −2
Original line number Diff line number Diff line
import { redirect } from '@sveltejs/kit';
import type { PageParentData, PageServerLoad } from './$types';
import { getAssignmentsByClassId } from '$lib/server/db/assignment';
import _ from 'lodash';
import { db } from '$lib/server/db';

@@ -33,7 +32,6 @@ export const load = (async ({ parent, locals }) => {
		entries: Array<{
			name: string,
			title: string,
			groups: Array<{}>
		}>
	};
}) satisfies PageServerLoad;
+0 −1
Original line number Diff line number Diff line
@@ -2,7 +2,6 @@ import { error, redirect } from '@sveltejs/kit';
import type { PageParentData, PageServerLoad } from './$types';
import _ from 'lodash';
import { db } from '$lib/server/db';
import { log } from "$lib/server/log"

type GradeGroupData = {
	name: string,
+1 −1
Original line number Diff line number Diff line
@@ -27,7 +27,7 @@
		}),
		...data.groups.map((group) =>
			table.column({
				accessor: group.name,
				accessor: () => group.name,
				header: group.title
			})
		),
+1 −1
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ export const load = (async ({ parent }) => {
                const { feedback } = s
                num += feedback.isValid ? 1 : 0;
                const penaltyScore = cal(num)
                const originalScore = await getFeedbackScore(s.feedback)
                const originalScore = getFeedbackScore(s.feedback)
                const finalScore = _.max([originalScore - penaltyScore, 0]) || 0;

                if (finalScore != feedback.score) {
Loading