fix msync pointer alignment (e87ba590) · Commits · github_fork / Clip

fnordmetric-core/src/io/pagemanager.cc

+20 −11

Original line number	Diff line number	Diff line
		@@ -95,13 +95,16 @@ MmapPageManager::MmapPageManager(
		PageManager(1, file_size),
		filename_(filename),
		file_size_(file_size),
		current_mapping_(nullptr) {}
		current_mapping_(nullptr) {
		sys_page_size_ = sysconf(_SC_PAGESIZE);
		}

		MmapPageManager::MmapPageManager(MmapPageManager&& move) :
		PageManager(std::move(move)),
		filename_(move.filename_),
		file_size_(move.file_size_),
		current_mapping_(move.current_mapping_) {
		current_mapping_(move.current_mapping_),
		sys_page_size_(move.sys_page_size_) {
		move.file_size_ = 0;
		move.current_mapping_ = nullptr;
		}
		@@ -134,7 +137,11 @@ std::unique_ptr<PageManager::PageRef> MmapPageManager::getPage(
		file_size_ = new_size;
		}

		auto page_ref = new MmappedPageRef(page, getMmappedFile(last_byte));
		auto page_ref = new MmappedPageRef(
		page,
		getMmappedFile(last_byte),
		sys_page_size_);

		mmap_mutex_.unlock();

		return std::unique_ptr<PageManager::PageRef>(page_ref);
		@@ -196,17 +203,19 @@ void MmapPageManager::MmappedFile::decrRefs() {

		MmapPageManager::MmappedPageRef::MmappedPageRef(
		const PageManager::Page& page,
		MmappedFile* file) :
		MmappedFile* file,
		size_t sys_page_size) :
		PageRef(page),
		file_(file) {

		file_(file),
		sys_page_size_(sys_page_size) {
		file_->incrRefs();
		}

		MmapPageManager::MmappedPageRef::MmappedPageRef(
		MmapPageManager::MmappedPageRef&& move) :
		PageRef(move.page_),
		file_(move.file_) {
		file_(move.file_),
		sys_page_size_(move.sys_page_size_) {
		move.file_ = nullptr;
		}

		@@ -215,10 +224,10 @@ void* MmapPageManager::MmappedPageRef::getPtr() const {
		}

		void MmapPageManager::MmappedPageRef::sync(bool async /* = false */) const {
		msync(
		((char *) getPtr()) + page_.offset,
		page_.size,
		async ? MS_SYNC : MS_ASYNC);
		uintptr_t ptr = (uintptr_t) ((char *) getPtr()) + page_.offset;
		auto sptr = (ptr / (sys_page_size_)) * sys_page_size_;
		auto ssize = page_.size + (ptr - sptr);
		msync((void *) sptr, ssize, async ? MS_SYNC : MS_ASYNC);
		}

		MmapPageManager::MmappedPageRef::~MmappedPageRef() {

fnordmetric-core/src/io/pagemanager.h

+3 −1

Original line number	Diff line number	Diff line
		@@ -134,13 +134,14 @@ public:

		class MmappedPageRef : public PageManager::PageRef {
		public:
		MmappedPageRef(const PageManager::Page& page, MmappedFile* file);
		MmappedPageRef(const PageManager::Page& page, MmappedFile* file, size_t sys_page_size);
		MmappedPageRef(MmappedPageRef&& move);
		MmappedPageRef(const MmappedPageRef& copy) = delete;
		MmappedPageRef& operator=(const MmappedPageRef& copy) = delete;
		~MmappedPageRef();
		void sync(bool async = false) const override;
		protected:
		size_t sys_page_size_;
		void* getPtr() const override;
		MmappedFile* file_;
		};
		@@ -174,6 +175,7 @@ protected:
		size_t file_size_;
		MmappedFile* current_mapping_;
		std::mutex mmap_mutex_;
		size_t sys_page_size_;
		};

Admin message