proper chart rendering in query editor result view (1d39abad) · Commits · github_fork / Clip

fnordmetric-doc/TODO

+2 −2

Original line number	Diff line number	Diff line
		@@ -13,12 +13,11 @@

		[ frontend ]
		- clean up sql result view
		- syntax highlighting
		- embed popup
		- hover flyoouts for button bar in sql editor "Refresh, Change View and use CTRL+enter"
		- better error message style
		- compare with yesterday in metric preview widget
		- metric preview widget: auto refresh (on/off)
		- refresh btn in metric preview widget

		[ release ]
		- functions: round, median, percentile
		@@ -32,6 +31,7 @@
		- do I need an external database

		[ feature q ]
		- metric preview widget: auto refresh (on/off)
		- version numbers
		- deb pkg
		- homebrew pkg

+20 −1

Original line number	Diff line number	Diff line
		@@ -24,8 +24,27 @@ FnordMetric.util.queryResultView = function() {
		var chart_pane = document.createElement("div");
		chart_pane.className = "chart_container";
		chart_pane.setAttribute("id", "chart_container");

		var controls = document.createElement("div");
		controls.className = "metric_preview_secondary_controls";
		controls.innerHTML = "<a>Result Chart</a>"
		chart_pane.appendChild(controls);

		var controls_embed = FnordMetric.createButton(
		"#", "btn", "<i class='fa fa-share'></i> Embed");
		controls.appendChild(controls_embed);
		controls_embed.onclick = function(e) {
		e.preventDefault();
		FnordMetric.util.embedPopup(elem).render()
		}

		var controls = document.createElement("div");

		if (chart != undefined) {
		chart_pane.innerHTML = chart.svg;
		var svg = document.createElement("div");
		svg.className = "svg";
		svg.innerHTML = chart.svg;
		chart_pane.appendChild(svg);
		}
		elem.appendChild(chart_pane);
		}

+4 −3

Original line number	Diff line number	Diff line
		@@ -495,10 +495,11 @@ input {
		}

		.result_pane .chart_container {
		margin-top: 30px;
		text-align:center;
		padding: 0px 15px;
		margin-bottom: 70px;
		}

		.result_pane .chart_container .svg {
		padding: 20px 10px;
		}

		.error_box {