Commit fffec50f authored by Alexander Shishkin's avatar Alexander Shishkin Committed by Ingo Molnar
Browse files

perf/x86/intel/pt: Use helpers to obtain ToPA entry size 



There are a few places in the PT driver that need to obtain the size of
a ToPA entry, some of them for the current ToPA entry in the buffer.
Use helpers for those, to make the lines shorter and more readable.

Signed-off-by: default avatarAlexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: http://lkml.kernel.org/r/20190821124727.73310-3-alexander.shishkin@linux.intel.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 90583af6

arch/x86/events/intel/pt.c

+6 −6
Original line number Diff line number Diff line
@@ -572,6 +572,7 @@ struct topa { 


/* make -1 stand for the last table entry */

#define TOPA_ENTRY(t, i) ((i) == -1 ? &(t)->table[(t)->last] : &(t)->table[(i)])

#define TOPA_ENTRY_SIZE(t, i) (sizes(TOPA_ENTRY((t), (i))->size))



/**

 * topa_alloc() - allocate page-sized ToPA table
@@ -771,7 +772,7 @@ static void pt_update_head(struct pt *pt) 


	/* offset of the current output region within this table */

	for (topa_idx = 0; topa_idx < buf->cur_idx; topa_idx++)

		base += sizes(buf->cur->table[topa_idx].size);

		base += TOPA_ENTRY_SIZE(buf->cur, topa_idx);



	if (buf->snapshot) {

		local_set(&buf->data_size, base);
@@ -800,7 +801,7 @@ static void *pt_buffer_region(struct pt_buffer *buf) 
 */

static size_t pt_buffer_region_size(struct pt_buffer *buf)

{

	return sizes(buf->cur->table[buf->cur_idx].size);

	return TOPA_ENTRY_SIZE(buf->cur, buf->cur_idx);

}



/**
@@ -830,7 +831,7 @@ static void pt_handle_status(struct pt *pt) 
		 * know.

		 */

		if (!intel_pt_validate_hw_cap(PT_CAP_topa_multiple_entries) ||

		    buf->output_off == sizes(TOPA_ENTRY(buf->cur, buf->cur_idx)->size)) {

		    buf->output_off == pt_buffer_region_size(buf)) {

			perf_aux_output_flag(&pt->handle,

			                     PERF_AUX_FLAG_TRUNCATED);

			advance++;
@@ -925,8 +926,7 @@ static int pt_buffer_reset_markers(struct pt_buffer *buf, 
	unsigned long idx, npages, wakeup;



	/* can't stop in the middle of an output region */

	if (buf->output_off + handle->size + 1 <

	    sizes(TOPA_ENTRY(buf->cur, buf->cur_idx)->size)) {

	if (buf->output_off + handle->size + 1 < pt_buffer_region_size(buf)) {

		perf_aux_output_flag(handle, PERF_AUX_FLAG_TRUNCATED);

		return -EINVAL;

	}
@@ -1032,7 +1032,7 @@ static void pt_buffer_reset_offsets(struct pt_buffer *buf, unsigned long head) 
	buf->cur = (struct topa *)((unsigned long)buf->topa_index[pg] & PAGE_MASK);

	buf->cur_idx = ((unsigned long)buf->topa_index[pg] -

			(unsigned long)buf->cur) / sizeof(struct topa_entry);

	buf->output_off = head & (sizes(buf->cur->table[buf->cur_idx].size) - 1);

	buf->output_off = head & (pt_buffer_region_size(buf) - 1);



	local64_set(&buf->head, head);

	local_set(&buf->data_size, 0);

CRA Git | Maintained and supported by SUSTech CRA and CCSE