Commit fff8c9eb authored Dec 11, 2017 by Stefan Raspl Committed by Paolo Bonzini Dec 14, 2017

tools/kvm_stat: fix child trace events accounting



Child trace events were included in calculation of the overall total,
which is used for calculation of the percentages of the '%Total' column.
However, the parent trace envents' stats summarize the child trace
events, hence we'd incorrectly account for them twice, leading to
slightly wrong stats.
With this fix, we use the correct total. Consequently, the sum of the
child trace events' '%Total' column values is identical to the
respective value of the respective parent event. However, this also
means that the sum of the '%Total' column values will aggregate to more
than 100 percent.

Signed-off-by: Stefan Raspl <raspl@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent b74faa93

tools/kvm/kvm_stat/kvm_stat

+3 −3

Original line number	Diff line number	Diff line
		@@ -1092,14 +1092,14 @@ class Tui(object):
		# sort by totals
		return (0, -stats[x][0])
		total = 0.
		for val in stats.values():
		total += val[0]
		for key in stats.keys():
		if key.find('(') is -1:
		total += stats[key][0]
		if self._sorting == SORT_DEFAULT:
		sortkey = sortCurAvg
		else:
		sortkey = sortTotal
		for key in sorted(stats.keys(), key=sortkey):

		if row >= self.screen.getmaxyx()[0]:
		break
		values = stats[key]

tools/kvm/kvm_stat/kvm_stat.txt

+2 −0

Original line number	Diff line number	Diff line
		@@ -50,6 +50,8 @@ INTERACTIVE COMMANDS
		s:: set update interval

		x:: toggle reporting of stats for child trace events
		:: Note: The stats for the parents summarize the respective child trace
		events

		Press any other key to refresh statistics immediately.

Admin message